viirya opened a new pull request, #17:
URL: https://github.com/apache/spark-connect-gateway/pull/17
### What changes were proposed in this pull request?
The Redis-backed integration tests in `scg-store-redis` and `scg-ratelimit`
are
marked `#[ignore = "requires Docker"]`, so `cargo test --workspace` skips
them and
they have never run in CI. That leaves 9 integration tests uncovered:
- **`scg-store-redis`** — the Redis `AffinityStore` round-trips:
bind/resolve/forget, session TTL expiry, atomic bind-if-absent, the op
reverse
index, and two stores sharing one Redis.
- **`scg-ratelimit`** — the distributed token bucket: burst
admit-then-reject,
refill after wait, per-tenant isolation, and two replicas sharing a bucket.
These tests bring up their own Redis container through `testcontainers`, and
the
GitHub-hosted runners already provide a Docker daemon, so no `services:`
block or
extra setup is needed. This adds one CI step that runs them explicitly:
```
cargo test -p scg-store-redis -p scg-ratelimit -- --ignored
```
The `#[ignore]` markers stay, so a local `cargo test` still needs no Docker
— CI
opts in instead. The step is added to the existing job rather than a new
one, so
it reuses the already-built artifacts instead of recompiling the workspace.
### Why are the changes needed?
The Redis backends are what make multi-replica HA work (cross-replica session
affinity and a shared rate-limit bucket), and none of that behaviour was
verified
by CI. A regression in either would have gone unnoticed.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Ran the tests locally with a Docker daemon available:
`cargo test -p scg-store-redis -p scg-ratelimit -- --ignored` — 9 passed
(store-redis 5, ratelimit 4) in about 10 seconds including container
startup, so
the added CI time is small. The rest of the quartet is unchanged. This PR's
own
CI run exercises the new step on a GitHub-hosted runner.
### Was this patch authored or co-authored using generative AI tooling?
Yes, co-authored with Claude Code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
