LuciferYang commented on PR #55924: URL: https://github.com/apache/spark/pull/55924#issuecomment-5509907587
After this PR migrates all three call sites to getSuffixLength/getSuffixInto, getBytes(int) has no callers left in the repo, and it is not part of Spark's public API (package-private constructor, instances never leave the parquet package), so there is no compatibility argument to keep it. Since the PR's goal is precisely to retire this allocate-a-ByteBuffer-per-call path, deleting it here would finish the job. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
