dongjoon-hyun opened a new pull request, #501: URL: https://github.com/apache/spark-connect-swift/pull/501
### What changes were proposed in this pull request? This PR aims to replace the exact version-prefix checks in the test suites with lower-bound version comparisons, so that the version-gated tests also run on newer Apache Spark servers. - `SQLTests`: `queriesForSpark42Only` is renamed to `queriesForSpark42AndLater` and the skip condition becomes `spark.version < "4.2"` instead of `!spark.version.starts(with: "4.2")`. - `SparkConnectClientTests`: the five Declarative Pipelines API gates become `response.sparkVersion.version >= "4.1"` instead of `response.sparkVersion.version.starts(with: "4.1")`. ### Why are the changes needed? The existing conditions match a single feature version only, so the tests are silently skipped on any later server. | Test | Spark 4.0 | Spark 4.1 | Spark 4.2 | Spark 4.3 | | --- | --- | --- | --- | --- | | `SQLTests`: `geography.sql`, `geometry.sql`, `time.sql` | skipped | skipped | run | **skipped** | | `SparkConnectClientTests`: `createDataflowGraph`, `defineSqlGraphElements` | skipped | run | **skipped** | **skipped** | In other words, the newly added `integration-test-mac-spark43` job (SPARK-59156) loses the `TIME`/geospatial SQL coverage, and the Declarative Pipelines APIs have not been covered by any job since Apache Spark 4.2.0. Since these features are available in all later versions, the gates should be lower bounds. This also matches the style already used across the test suites, e.g. `if await spark.version >= "4.2"`. ### Does this PR introduce _any_ user-facing change? No. This is a test-only change. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
