srielau commented on code in PR #58413:
URL: https://github.com/apache/spark/pull/58413#discussion_r3917101068
##########
connector/protobuf/src/test/scala/org/apache/spark/sql/protobuf/ProtobufDescriptorFileReadSuite.scala:
##########
@@ -79,6 +80,26 @@ class ProtobufDescriptorFileReadSuite extends
SharedSparkSession with ProtobufTe
assert(r)
}
+ test("SPARK-59112: CHAR/VARCHAR descriptor paths use the three-argument
overload") {
+ withSQLConf(SQLConf.CHAR_VARCHAR_STANDARD_SEMANTICS.key -> "true") {
+ val fileUri = new File(descPath).getCanonicalFile.toURI.toString
+ spark.range(1).selectExpr("CAST(NULL AS BINARY) AS
value").createOrReplaceTempView("t_pb")
Review Comment:
Addressed in f69e09ab97f. The SPARK-59112 test now encodes a non-null
SimpleMessageJavaTypes payload and decodes it with CHAR/VARCHAR descriptor-path
expressions, asserting the decoded fields. to_protobuf still uses CHAR/VARCHAR
descriptor paths as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
