ulysses-you commented on PR #58466: URL: https://github.com/apache/spark/pull/58466#issuecomment-5519158050
Thanks for the detailed review. 1. Adopted in b5ac9723bd7: `get()` keeps throwing, and a null-returning `getOrNull()` now serves the constructor, `getMetadata` and `updateBatch`. `read()` and both iterators stay at the base shape, so the exception is built in one place per store. 2. Verified dead (nothing inside the try bodies can throw `NoSuchElementException`) and dropped in b5ac9723bd7; `testDeleteEdgeCases` pins down that deleting a missing entry is a silent no-op. 3. Agreed; keeping the existing behavior. Skipping dangling index entries or using a distinct exception type works as a follow-up. 4./5./6. Agreed, left for a follow-up to keep this PR focused. 7. Agreed, separate JIRA. 8. Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
