Spenserrrr commented on PR #58504: URL: https://github.com/apache/spark/pull/58504#issuecomment-5532343545
Thanks for the feedback! I added the number to the PR description. And yes it is not a big improvement on its own. It is saving ~20us of fixed cost per column, so it only shows as a ratio when per-row work is small: 1.7x on 50 `long` columns, but 1.06x on `timestamp` at 10k rows. Profiling also turned up two more per-column costs of the same kind in this path. Happy to fold them in here if you'd rather see the whole per-column budget in one PR. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
