uros-b commented on code in PR #58242:
URL: https://github.com/apache/spark/pull/58242#discussion_r3936108302
##########
sql/api/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -5442,6 +5442,36 @@ object functions {
*/
def factorial(e: Column): Column = Column.fn("factorial", e)
+ /**
Review Comment:
`gcd`/`lcm` sit between `factorial` (5443) and `floor` (5488). The section
is strictly alphabetical (cos, cosh, cot, csc, exp, expm1, factorial, floor,
greatest, hex, hypot, least, ln, log), so `gcd` belongs after the `floor`
overloads / before `greatest` (~5526) and `lcm` after the last `hypot` overload
/ before `least` (~5696).
`__init__.py` and `functions.rst` place both correctly, so this file is the
lone inconsistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
