pratham76 commented on code in PR #57994:
URL: https://github.com/apache/spark/pull/57994#discussion_r3943392066
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetPartitionDiscoverySuite.scala:
##########
@@ -1443,6 +1443,40 @@ class ParquetV2PartitionDiscoverySuite extends
ParquetPartitionDiscoverySuite {
assert(s"p_int=${ExternalCatalogUtils.DEFAULT_PARTITION_NAME}" === path)
}
+ test("SPARK-51830: insertInto with string partition values " +
+ "when validatePartitionColumns is disabled") {
+ withTempDir { base =>
+ val legacyPartitionDir = new java.io.File(base, "p_int=partition_value")
+ legacyPartitionDir.mkdirs()
+ makeParquetFile(
+ (1 to 5).map(i => ParquetData(i, s"str$i")),
+ legacyPartitionDir)
+
+ val df = spark.read.parquet(base.getCanonicalPath)
+ df.createOrReplaceTempView("legacy_table")
+
+ withTempView("legacy_table") {
+ checkAnswer(
+ sql("SELECT * FROM legacy_table"),
+ (1 to 5).map(i => Row(i, s"str$i", "partition_value")))
+
+ val newData = Seq((6, "str6")).toDF("intField", "stringField")
+ intercept[NumberFormatException] {
+ newData.write.mode("append").insertInto("legacy_table")
+ }
+
+ withSQLConf(SQLConf.VALIDATE_PARTITION_COLUMNS.key -> "false") {
+ newData.write.mode("append").insertInto("legacy_table")
+
+ checkAnswer(
+ sql("SELECT * FROM legacy_table ORDER BY intField"),
+ (1 to 6).map(i => Row(i, s"str$i", "partition_value")))
+ }
+ }
+ }
+ }
Review Comment:
@uros-b Thanks for the review, you're right — the earlier tests only covered
PartitioningUtils.getPathFragment in isolation. I've added end-to-end coverage
in InsertSuite that exercises both call sites changed in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
