stevomitric commented on code in PR #58418:
URL: https://github.com/apache/spark/pull/58418#discussion_r3944403737
##########
python/pyspark/sql/tests/connect/test_parity_types.py:
##########
@@ -22,6 +22,34 @@
class TypesParityTests(TypesTestsMixin, ReusedConnectTestCase):
+ # SPARK-57462: nanosecond timestamp types are not yet supported over Spark
Connect, whose
+ # data path goes through Arrow (to_arrow_type /
ArrowTableToRowsConversion). These inherited
+ # tests build or collect nanosecond data and are covered by the classic
(non-Connect) suite;
+ # pending the Arrow follow-up they are skipped here.
+ @unittest.skip("SPARK-57462: nanosecond timestamp types are pending
Connect/Arrow support.")
+ def test_timestamp_nanos_type(self):
+ super().test_timestamp_nanos_type()
+
+ @unittest.skip("SPARK-57462: nanosecond timestamp types are pending
Connect/Arrow support.")
+ def test_timestamp_nanos_type_preview_flag_off(self):
+ super().test_timestamp_nanos_type_preview_flag_off()
+
+ @unittest.skip("SPARK-57462: nanosecond timestamp types are pending
Connect/Arrow support.")
+ def test_timestamp_nanos_type_python_udf(self):
+ super().test_timestamp_nanos_type_python_udf()
+
+ @unittest.skip("SPARK-57462: nanosecond timestamp types are pending
Connect/Arrow support.")
+ def test_timestamp_nanos_type_map_key_collision(self):
+ super().test_timestamp_nanos_type_map_key_collision()
Review Comment:
fixed, used `check_error` for the map-key collision; FEATURE_NOT_ENABLED
error for flag-off
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
