zhangxinyao88 opened a new pull request, #58556:
URL: https://github.com/apache/spark/pull/58556

   ### What changes were proposed in this pull request?
   
   Update `SQLQueryTestHelper.getSparkSettings` so that a comma is treated as a 
setting separator only when it is followed by another configuration key. This 
preserves commas inside configuration values.
   
   ### Why are the changes needed?
   
   `--SET` directives can contain values with commas, such as 
`spark.sql.optimizer.excludedRules`. The previous parser split those values 
incorrectly.
   
   ### Does this PR introduce any user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Added focused unit coverage for single and multiple settings, multiple 
directives, comma-containing values, and unrelated comments.
   
   Ran:
   
   ```text
   build/sbt 'sql/testOnly 
org.apache.spark.sql.SQLQueryTestHelperSuite'\n```\n\nAll 6 tests passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to