zhengruifeng commented on code in PR #58435:
URL: https://github.com/apache/spark/pull/58435#discussion_r3950148685
##########
python/pyspark/sql/tests/connect/streaming/test_parity_listener.py:
##########
@@ -84,6 +98,50 @@ def onQueryTerminated(self, event):
self.terminated.append(event)
[email protected](not should_test_connect, connect_requirement_message)
+class StreamingQueryListenerBusResponseTests(unittest.TestCase):
Review Comment:
These are Connect-only unit tests: they instantiate
`StreamingQueryListenerBus` directly and have no classic counterpart, while
this module's existing suite is the Connect implementation of
`StreamingListenerTestsMixin`. Please move this class to a Connect-specific
`streaming/test_listener.py` so `test_parity_listener.py` remains limited to
shared classic/Connect parity coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]