Licht-T commented on PR #56848: URL: https://github.com/apache/spark/pull/56848#issuecomment-5571431019
@uros-b Thanks for reviewing! > The template still says "Does this PR introduce any user-facing change? No." That is no longer true. > Mention SPARK-57769 in the title > Treat #56908 as superseded Done. > 1. Left edge of the transition table is unbounded; the right edge is not Fixed with your second option. > 2. truncTimestamp Scaladoc is stale Rewritten. > 3. SPARK-57769 is only tested through DateTimeUtils, not TruncTimestamp ... WEEK has no dedicated midnight-overlap fixture. Added a `checkEvaluation` test (interpreted + codegen) over the Havana MONTH and Berlin QUARTER overlaps, plus a WEEK fixture: `Asia/Jerusalem` 2001-09-24, a Monday-midnight fall-back. The same fixture is added to the `DateTimeUtilsSuite` regression test. > 1. The on-transition unit test still describes the old previousTransition(hi - 1) anchor. Fixed. > 2. Interpreted eval still does new ZoneOffsetCache(zoneId) per row ... Please verify. Verified safe: the instance is confined to the `eval` call stack and never escapes onto the expression, so concurrent evaluation shares nothing mutable; the only cross-thread state is the `ConcurrentHashMap` of immutable transition tables. > Still can't seem to run workflows here Rebased with master and pushed a new commit. Hope this works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
