sweb commented on code in PR #58010:
URL: https://github.com/apache/spark/pull/58010#discussion_r3940318299
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala:
##########
@@ -143,6 +143,15 @@ private[spark] class BasicExecutorFeatureStep(
case _ => Nil
}.getOrElse(Nil)
+ // SparkConf.isExecutorStartupConf withholds the spark.ssl.* passwords
from the
+ // executor conf. Pass them through the environment, as the standalone
worker
+ // does in CommandUtils. Names the user already supplies via
+ // spark.kubernetes.executor.secretKeyRef are skipped, so that an
explicit
+ // secret reference is not shadowed by a literal password in the pod
spec.
+ val sslRpcPasswords = secMgr.getEnvironmentForSslRpcPasswords.filterNot {
+ case (name, _) => kubernetesConf.secretEnvNamesToKeyRefs.contains(name)
Review Comment:
Addressed in
https://github.com/apache/spark/pull/58010/changes/2285333d0e4a08803f884b27c50766bf3bb9cfd5
- I also adjusted the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
