szehon-ho commented on code in PR #58483:
URL: https://github.com/apache/spark/pull/58483#discussion_r3963937506
##########
sql/pipelines/src/main/scala/org/apache/spark/sql/pipelines/autocdc/Scd2BatchProcessor.scala:
##########
@@ -194,6 +194,9 @@ case class Scd2BatchProcessor(
colName = AutoCdcReservedNames.cdcMetadataColName,
col = Scd2BatchProcessor.constructCdcMetadataCol(
recordStartAt = changeArgs.sequencing,
+ // TODO (SPARK-59183): actually populate version map according to
ignore-null selection and
+ // actual authorship in microbatch.
+ versionMap = F.lit(null),
Review Comment:
Could writing `null` for every row here lose information needed by the
future ignore-null implementation? In particular, a column absent from an event
and a column explicitly set to null would have identical persisted values and
version maps. How will the later implementation distinguish the unauthored
value from the authored null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
