stevomitric commented on code in PR #58226:
URL: https://github.com/apache/spark/pull/58226#discussion_r3966178193
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVOptions.scala:
##########
@@ -124,7 +124,7 @@ class CSVOptions(
val extension = {
val ext = parameters.getOrElse(EXTENSION, "csv")
- if (ext.size != 3 && !ext.forall(_.isLetter)) {
+ if (ext.size != 3 || !ext.forall(_.isLetter)) {
Review Comment:
I don't understand why we are limiting ourselves to just 3 character
extensions. You mention that its because of the error message - but shouldn't
functionality dictate error messages rather then vice versa?
As far as i see it there is no technical reason for this limitation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
