superdiaodiao commented on PR #57298: URL: https://github.com/apache/spark/pull/57298#issuecomment-5598292080
Ping — this one is still open and still green, and I'd like to get it unblocked. @uros-b you reviewed on Jul 17 and both of your points are addressed (2254bf0): the test now uses the suite-idiomatic `checkError` pattern instead of matching on the message, and coverage was extended from `cube` alone to `rollup` and `groupingSets` as well. It is test-only — +30/-0 in a single file, no production code touched. I'm pinging you specifically rather than broadly because you merged the most recent change to this exact file (SPARK-58951, Sep 4) and three of its last ten commits, so this is squarely in an area you're actively working in. @cloud-fan as the alternative: you've merged six of the last fifteen commits to `DataFrameAggregateSuite.scala`, most recently SPARK-58213 on Aug 20. If Uros is tied up, would you be willing to pick it up? Happy to rebase onto current master and re-run CI if that helps — the last full build was green, but it predates the Sep 4 change to this file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
