HyukjinKwon commented on code in PR #58189:
URL: https://github.com/apache/spark/pull/58189#discussion_r3973969499
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/PythonUDF.scala:
##########
@@ -285,6 +288,109 @@ trait PythonFuncExpression extends NonSQLExpression with
UserDefinedExpression {
}
+/**
+ * Stands in for a `_udf_param_N` placeholder in a transpiled option: a
reference to the call's
+ * `index`th argument (SPARK-58626).
+ *
+ * A reference and not a copy, so the argument stays put in
[[TranspiledPythonUDF.arguments]] and
+ * `ConvertToCatalyst` decides per call whether to compute it once in a
Project below the operator.
+ * [[substitute]] copies the argument to each use site only where repeating it
is as cheap as a
Review Comment:
Scaladoc: this `[[substitute]]` link won't resolve. `substitute` is a member
of the companion `object TranspiledUDFParameter` (below), not of the `case
class` this doc is attached to, and a bare-name link can't reach a
companion-object member. Qualify it as `[[TranspiledUDFParameter.substitute]]`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
