dongjoon-hyun opened a new pull request, #550:
URL: https://github.com/apache/spark-connect-swift/pull/550

   ### What changes were proposed in this pull request?
   
   This PR aims to pass the plan ID in `DataFrame.colRegex`, like PySpark, now 
that `DataFrame` relations have plan IDs (SPARK-59414).
   
   - Set `planID` of `UnresolvedRegex` in `colRegex`.
   - Update the doc comment. The server uses the plan ID only for a column name 
without backticks, which is resolved as a regular column reference bound to the 
`DataFrame` like `col(_:)`. A regex enclosed in backticks is still not bound to 
the `DataFrame`.
   
   ### Why are the changes needed?
   
   When SPARK-59399 added `colRegex`, this client had no plan IDs. As a result, 
a column name without backticks could not be disambiguated when both sides of a 
join had it.
   
   ```swift
   let df = try await spark.range(3)
   let df1 = await df.filter("id > 0")
   let df2 = await df.select("id")
   let joined = await df1.join(df2, joinExprs: df1.colRegex("id") == 
df2.colRegex("id"))
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   
   No. `colRegex` is not released yet.
   
   ### How was this patch tested?
   
   Pass the CIs with the newly added test case.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Opus 5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to