ChuckLin2025 commented on PR #58440: URL: https://github.com/apache/spark/pull/58440#issuecomment-5630391484
Thanks for the reviews, @uros-b @tdcmeehan @cloud-fan! CI is now green — the earlier K8s Integration failure was fork-runner infra (setup failed before any test ran, no `integration-tests.log`) and cleared after merging latest master. All feedback has been addressed: - structured MDC logging at the detection site (@uros-b) - framed as the FIFO stream-callback ordering invariant rather than a general corruption detector, with the scope stated explicitly (@tdcmeehan) - narrowed the collateral-retry wording to match behavior — polled callback fails with an `IOException` (retried by `RetryingBlockTransferor`), the desynced connection is closed and its remaining outstanding requests are failed for callers to retry where supported (@cloud-fan) @mridulm @Ngone51 — this is a small `network-common` change on the shuffle stream-fetch path; would you have a moment to take a look, given your transport expertise? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
