stevomitric commented on code in PR #58675:
URL: https://github.com/apache/spark/pull/58675#discussion_r3987809833
##########
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##########
@@ -1147,13 +1148,12 @@ public UTF8String trimRight(UTF8String trimString) {
// the source string.
int trimEnd = numBytes - 1;
while (numChars > 0) {
- UTF8String searchChar = copyUTF8String(
Review Comment:
we still allocate two [numBytes] arrays regardless of match count - is it
possible to optimize on that too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
