Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6836#discussion_r32594967
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
 ---
    @@ -255,3 +257,39 @@ case class Pow(left: Expression, right: Expression)
           """
       }
     }
    +
    +case class Round(left: Expression, right: Expression)
    --- End diff --
    
    We can simply override the `def left` and `def right` methods. The `left` 
or `right` here is meaningless for `Round`. 
    However, the biggest concern here is, seems the `Round` in Hive only accept 
the constant value for `scala`, which mean the `Round` is a `UnaryExpression`, 
and the second argument will be just `Int`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to