cloud-fan commented on code in PR #58606:
URL: https://github.com/apache/spark/pull/58606#discussion_r3999374136
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -270,6 +281,8 @@ object AnalysisContext {
resolutionPathEntries = function.functionStoredResolutionPath
.map(CatalogManager.deserializePathEntriesOrFail(
_, "SQL function", function.name.unquotedString)),
+ // See the same reset in `withAnalysisContext(viewDesc)`.
+ referredTempVariableNamesUnderIdentifier = mutable.LinkedHashSet.empty,
Review Comment:
Addressed in the current head: SQL-function analysis now shares the
enclosing accumulator, and the composed function-in-view regression is covered.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"inline:3995050244","thread_id":"inline:3995050244","verdict_sha256":"12b7f981564f986cf8d4f4a9b51e54d32eca69438988a6670d47d8c183663030"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
