nchammas commented on code in PR #58555:
URL: https://github.com/apache/spark/pull/58555#discussion_r4009463381
##########
dev/sparktestsupport/modules.py:
##########
@@ -36,32 +36,140 @@
# - `.gitignore`-style patterns would be ideal but don't have support in the
# standard library.
ignored_file_patterns = (
- ".asf.yaml",
- ".gitignore",
+ # Contributor docs.
"AGENTS.md",
+ "CLAUDE.md",
"CONTRIBUTING.md",
+ "PULL_REQUEST_TEMPLATE",
"README.md",
+ "SECURITY.md",
+ # License and NOTICE files, including bundled third-party licenses.
"/LICENSE-binary",
+ "/LICENSE",
+ "/licenses-binary/",
+ "/licenses/",
"/NOTICE-binary",
- "/scalastyle-config.xml",
- "/SECURITY.md",
+ "/NOTICE",
+ # Git and ASF metadata.
+ ".asf.yaml",
+ ".gitattributes",
+ ".gitignore",
+ # Build and test workflow wrappers or schedulers.
+ "/.github/workflows/benchmark.yml",
+ "/.github/workflows/branch*_scheduler.yml",
+ "/.github/workflows/build_codegen_jdk.yml",
+ "/.github/workflows/build_coverage.yml",
+ "/.github/workflows/build_java*.yml",
+ "/.github/workflows/build_main.yml",
Review Comment:
I'm not following either. Let me restate why I added these lines here.
Right now, if a PR touches `build_main.yml` and nothing else (as an
example), `sparktestsupport` will fall through to the `root` module and then
run all tests -- Scala, Python, anything referenced in `modules.py` -- as part
of PR CI. But none of those tests exercise `build_main.yml`. So it's purely a
waste.
By adding this file to the ignore list, we make sure that if a PR only
touches `build_main.yml` it _does not_ fall through to the `root` module.
Instead, it builds nothing.
Are you saying it's a mistake to add `build_main.yml` and friends to the
ignore list? If yes, could you illustrate with an example why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
