szehon-ho commented on PR #58756: URL: https://github.com/apache/spark/pull/58756#issuecomment-5670823912
I reviewed the latest patch and found no additional issues beyond the existing unresolved threads: - Accepted `PartitionPredicate`s can remove MERGE/delta filters even when evaluation fails open, potentially causing incorrect writes: https://github.com/apache/spark/pull/58756#discussion_r4001846479 - The new test scan builder bypasses runtime filtering, options, ordering, and scan-event behavior: https://github.com/apache/spark/pull/58756#discussion_r4001846487 - The fixture accepts predicate shapes its evaluator cannot handle, producing planning failures: https://github.com/apache/spark/pull/58756#discussion_r4001846490 The latest changes on `master` do not resolve these concerns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
