szehon-ho commented on code in PR #58792:
URL: https://github.com/apache/spark/pull/58792#discussion_r4011020850
##########
dev/merge_spark_pr.py:
##########
@@ -1449,8 +1455,12 @@ def resolve_jira_issue(
)
if all_inferred_present:
print(
- "JIRA issue %s already contains all inferred fix versions; no
update needed."
- % issue.key
+ "JIRA issue %s already contains all inferred fix versions; no
fix version "
+ "update needed." % issue.key
+ )
+ # A re-run may still have Affects Version/s sitting above the
unchanged fix set.
+ maybe_reconcile_jira_affects_versions(
Review Comment:
This covers the case where every inferred Fix Version is already present.
Could we also make the same call before the later return when the committer
declines an inferred addition? On a rerun, defaults are inferred from the
current unreleased versions, so an older already-merged PR can infer a version
absent from its resolved JIRA. The committer may correctly decline that
addition, but the current return then skips reconciliation and can leave, for
example, Fix Version `5.0.0` / Affects Version `6.0.0` unchanged. I think `n`
should reject only the proposed Fix Version addition, then reconcile using
`existing_fix_version_names` before returning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
