Yicong-Huang commented on PR #58729: URL: https://github.com/apache/spark/pull/58729#issuecomment-5675235666
Thanks for the review, Hyukjin! 1. Import cycle: good catch. I moved the base classes into a `_base.py` leaf module that both `__init__` and `_arrow` import, so the cycle is gone now. 2. `assert`: I actually started with `raise AssertionError`, but the `check_pyspark_custom_errors` linter rejects raising builtins, and adding a dedicated error condition felt like overkill for an internal dev-time invariant, so I kept `assert` to match the worker's style. Happy to switch to a custom error if you'd rather it survive `-O`. cc @zhengruifeng @gaogaotiantian, would appreciate your eyes on this too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
