uros-b commented on code in PR #58758:
URL: https://github.com/apache/spark/pull/58758#discussion_r4014672311
##########
core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala:
##########
@@ -1111,4 +1103,10 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])
private[spark] def valueClass: Class[_] = vt.runtimeClass
private[spark] def keyOrdering: Option[Ordering[K]] = Option(ord)
+
+ private def failOnHashPartitionerWithArrayKey(partitioner: Partitioner):
Unit = {
Review Comment:
Done, thank you!
##########
core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala:
##########
@@ -778,9 +776,7 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])
other3: RDD[(K, W3)],
partitioner: Partitioner)
: RDD[(K, (Iterable[V], Iterable[W1], Iterable[W2], Iterable[W3]))] =
self.withScope {
- if (partitioner.isInstanceOf[HashPartitioner] && keyClass.isArray) {
- throw SparkCoreErrors.hashPartitionerCannotPartitionArrayKeyError()
- }
+ failOnHashPartitionerWithArrayKey(partitioner)
Review Comment:
Done, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
