uros-b commented on PR #58826: URL: https://github.com/apache/spark/pull/58826#issuecomment-5683172553
Tests: good core coverage, but there are a few gaps. PlanParserSuite covers the important cases: one nested hint-shaped comment, two of them, deep nesting, a following real hint, and unclosed comments. SqlStatementSplitterSuite covers ; inside the nested hint-shaped comment. Still missing: - CliSuite SPARK-37555 / SPARK-37471 comments (above). - sql-tests comments.sql — that is the e2e path for nested comments; parser-only tests will not catch splitter/CLI drift. Do not hand-edit the .sql.out golden file; regenerate it. - A splitter unclosed case, e.g. SELECT 1; /* outer /*+ inner */ tail → hasUnclosedComment. - Prefix the new tests with SPARK-59536: so they grep with the ticket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
