szehon-ho commented on code in PR #58666:
URL: https://github.com/apache/spark/pull/58666#discussion_r4021545842


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2RelationSuite.scala:
##########
@@ -163,6 +163,103 @@ class DataSourceV2RelationSuite extends SparkFunSuite 
with SQLHelper {
     }
   }
 
+  test("DataSourceV2ScanRelation.computeStats matches column stats for names 
needing quoting") {
+    val colAttr = AttributeReference("col-1", IntegerType)()
+    val output = Seq(colAttr)
+    val scan = new Scan with SupportsReportStatistics {

Review Comment:
   Can we factor these repeated custom `Scan` implementations into a shared 
helper?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to