xumanbu commented on code in PR #53845:
URL: https://github.com/apache/spark/pull/53845#discussion_r4022023870
##########
core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:
##########
@@ -469,14 +469,20 @@ private[spark] class SparkSubmit extends Logging {
def avoidJarDownload(scheme: String): Boolean =
avoidJarDownloadSchemes.contains("*") ||
avoidJarDownloadSchemes.contains(scheme)
+ val avoidArchiveDownloadSchemes =
sparkConf.get(KUBERNETES_ARCHIVES_AVOID_DOWNLOAD_SCHEMES)
+
+ def avoidArchiveDownload(scheme: String): Boolean =
+ avoidArchiveDownloadSchemes.contains("*") ||
avoidArchiveDownloadSchemes.contains(scheme)
+
val filesLocalFiles = Option(args.files).map {
downloadResourcesToCurrentDirectory(_)
}.orNull
val updatedJars = Option(args.jars).map {
downloadResourcesToCurrentDirectory(_, avoidDownload =
avoidJarDownload)
}.orNull
val archiveLocalFiles = Option(args.archives).map {
- downloadResourcesToCurrentDirectory(_, true)
+ downloadResourcesToCurrentDirectory(_, isArchive = true,
+ avoidDownload = avoidArchiveDownload)
Review Comment:
The latest commits decouple them:
- Archives are downloaded and unpacked into the driver's working directory
again, so
`--conf spark.pyspark.python=./environment/bin/python` works as before.
- The option now only decides the URI that goes into `spark.archives`. For
the matched schemes
the original remote URI (with its fragment) is kept, so the executors
fetch from the remote
file system directly instead of the driver's file server.
- Renamed to `spark.kubernetes.archives.executorDirectFetchSchemes`, since
the old name
described something that did not happen. It is unreleased (4.3.0), so
there is no
compatibility cost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
