dongjoon-hyun commented on PR #826: URL: https://github.com/apache/spark-kubernetes-operator/pull/826#issuecomment-5698968964
@TQJADE, I updated the PR title and description to match the actual scope of this PR. The previous title, `Support publishing Kubernetes Event objects ...`, reads as general Kubernetes Events support. However, this PR publishes only `Warning` events for failures. Normal lifecycle events such as `DriverRequested`, `RunningHealthy` and `Succeeded` are not published. So I narrowed the title to: > [SPARK-59502] Support Kubernetes `Warning` events for `SparkApplication` and `SparkCluster` failures I also rewrote the description based on the current code: - A table of the published reasons (failure state names, `ReconcileError`, `CleanupError` and `StatusUpdateFailed`) and when each one is emitted. - Brief implementation notes on `ConfigurableEventRecorder`, the failure-state events in `StatusRecorder`, and the reason-based event key. - An explicit note that Normal lifecycle events are out of scope and can be handled in a follow-up. Could you check that the description is accurate, and fix anything I got wrong? One more request: the PR template asks for the tool name **and its version** in `Generated-by:`. Could you add the version you used? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
