LuciferYang commented on PR #58343:
URL: https://github.com/apache/spark/pull/58343#issuecomment-5708054595

   Thanks! 1 through 3 are in.
   
   1. The `serviceAccount` row's Modified value cell is back to `Value of 
spark.kubernetes.authenticate.driver.serviceAccountName`, the executor rule 
lives only in that row's description, and the `serviceAccountName` row now says 
"Same as `serviceAccount`".
   
   2. All three. The link is `[RBAC](running-on-kubernetes.html#rbac)`, and the 
closing sentence now reads: to keep the executor pods on the namespace's 
default account, name it explicitly, either in the template's 
`serviceAccountName` or in 
`spark.kubernetes.authenticate.executor.serviceAccountName`; Kubernetes creates 
it as `default` in every namespace.
   
   3. Reworded: the read is internal to the two feature steps, so there is no 
reason to widen that object's `@DeveloperApi` surface. That holds whatever the 
backport range turns out to be.
   
   4. Right, and it is the same `nonEmpty` question one line over: 
`.filter(_.nonEmpty)` on the two `lazy val`s covers the report and the write 
together. Added to SPARK-59518.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to