holdenk commented on code in PR #58619:
URL: https://github.com/apache/spark/pull/58619#discussion_r4042583749
##########
core/src/main/scala/org/apache/spark/deploy/ExternalShuffleService.scala:
##########
@@ -83,18 +83,25 @@ class ExternalShuffleService(sparkConf: SparkConf,
securityManager: SecurityMana
/** Create a new shuffle block handler. Factored out for subclasses to
override. */
protected def newShuffleBlockHandler(conf: TransportConf):
ExternalBlockHandler = {
- // Constrain registered localDirs to the configured local directories.
+ // Constrain registered localDirs to the configured local directories and,
when
+ // spark.shuffle.service.requireAppScopedLocalDirs is enabled, to the
registering
+ // application's own per-app directory (the Worker creates executor local
dirs under a
+ // path containing the app id). The check is opt-in: executors launched by
Workers that
+ // predate the per-app layout register unscoped paths and would be
rejected, so enable it
+ // only once every Spark application is upgraded.
Review Comment:
I think I might just change the others to Spark application since you can't
have mixed worker versions inside of a Spark application and the unit at which
someone would update their system is an a per-application level yeah?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
