LukaZdravic commented on PR #58823:
URL: https://github.com/apache/spark/pull/58823#issuecomment-5729638259
Thanks, both addressed:
1. Reworded the user-facing section to split the two cases:
- **Newly accepted** (previously `INVALID_TYPE`): `STRING` vs
`DATE`/`TIMESTAMP`/`TIMESTAMP_NTZ`/`TIME`, and `BOOLEAN`/`BINARY` vs `STRING`.
- **Already accepted, now correct**: `STRING` vs a number, which passed
analysis before but sorted the right buffer as `STRING` while comparing as the
numeric type, so it could match the wrong row. Sort and comparison now both use
the numeric common type.
2. Added a unit assertion that `TIME` vs `STRING` coerces to `TIME`. As you
noted, it reaches the coercion via the generic atomic fallback, like
`TIMESTAMP_NTZ`, not a temporal special case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
