vranes commented on code in PR #58853:
URL: https://github.com/apache/spark/pull/58853#discussion_r4049153405
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala:
##########
@@ -2871,13 +2825,12 @@ object AsOfJoin {
private def operandJoinSide(
expr: Expression,
leftSet: AttributeSet,
- rightSet: AttributeSet,
- syntacticIsLeft: Boolean): Option[Boolean] = {
+ rightSet: AttributeSet): Option[Boolean] = {
val refs = expr.references
if (refs.isEmpty) {
- // Literals, CURRENT_TIMESTAMP(), session variables, etc. have no column
refs;
- // use MATCH_CONDITION syntactic position (expr1/expr2) for join-side
assignment.
- Some(syntacticIsLeft)
+ // Constant operand (literal, current_timestamp(), session variable):
references no join
Review Comment:
nit: this comment could be tighter too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
