urosstan-db commented on PR #57714: URL: https://github.com/apache/spark/pull/57714#issuecomment-5745886086
Reviewed commit `68f352bf7b4f7656159bffb8e01d1fb9b411bc90`; no actionable code findings. The new tests check both plan pushdown and result equality against execution with join pushdown disabled. The `IF` condition addresses the earlier `LOWER` dialect-support issue, and the nonempty baseline guards match the settled discussion. One description correction: the motivation should refer to aggregates above joins, matching the grouped-aggregate test. It could also mention the conditional multi-way join coverage. Validation: inspected the code and existing CI results. The reviewed CI snapshot showed the Build check passing; local tests were not run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
