holdenk commented on code in PR #58696:
URL: https://github.com/apache/spark/pull/58696#discussion_r4055481733
##########
core/src/main/scala/org/apache/spark/deploy/Client.scala:
##########
@@ -275,6 +277,21 @@ object Client {
// scalastyle:on println
new ClientApp().start(args, new SparkConf())
}
+
+ /**
+ * Environment variables to forward to the driver. Only Spark-related
variables are forwarded,
+ * matching the REST submission client, unless
`spark.standalone.submit.filterEnvironment` is
+ * disabled, in which case the full environment of the submitting process is
forwarded.
+ */
+ private[deploy] def driverEnvironment(
+ conf: SparkConf,
+ env: Map[String, String]): Map[String, String] = {
+ if (conf.get(config.STANDALONE_SUBMIT_FILTER_ENVIRONMENT)) {
+ RestSubmissionClient.filterSystemEnvironment(env)
Review Comment:
Oh good point, let's drop SPARK_LOCAL_IP/HOSTNAME
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
