zgzzbws commented on code in PR #58730:
URL: https://github.com/apache/spark/pull/58730#discussion_r4056062345
##########
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/MountVolumesFeatureStepSuite.scala:
##########
@@ -573,4 +573,40 @@ class MountVolumesFeatureStepSuite extends SparkFunSuite {
assert(configuredPod.pod.getSpec.getVolumes.size() === 2)
assert(configuredPod.container.getVolumeMounts.size() === 2)
}
+
+ test("Mounts csi") {
+ val volumeConf = KubernetesVolumeSpec(
+ "testVolume",
+ "/mnt/disk1",
+ "",
+ "",
+ false,
Review Comment:
Done. Mounts csi now uses mountReadOnly = true and asserts csi.getReadOnly
=== true, so the test fails if .withReadOnly(...) is dropped. Also added a
driver-only case.
##########
docs/running-on-kubernetes.md:
##########
@@ -355,6 +356,15 @@ And, the claim name of a `persistentVolumeClaim` with
volume name `checkpointpvc
spark.kubernetes.driver.volumes.persistentVolumeClaim.checkpointpvc.options.claimName=check-point-pvc-claim
```
+And, a `csi` volume with volume name `data` can be specified using the
following properties. `options.driver` is required; `options.fsType`,
`options.nodePublishSecretName` (the name of a `Secret` in the pod's namespace)
and any `options.volumeAttributes.*` are optional:
+
+```
+spark.kubernetes.driver.volumes.csi.data.options.driver=file.csi.azure.com
+spark.kubernetes.driver.volumes.csi.data.options.fsType=ext4
Review Comment:
Switched the example to a generic driver name csi.example.com (and
csi-secret for consistency)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
