LuciferYang commented on PR #58868: URL: https://github.com/apache/spark/pull/58868#issuecomment-5750133456
You are right, and the clause is mine rather than the code's. A within-branch duplicate that every branch also holds is safe to hoist, which is why base and head agree on it; the shape the fix must refuse is the one confined to a single branch, the `[DIVIDE_BY_ZERO]` case. Dropped the clause, so the paragraph rests on the reason it already gave, consistency with a conditional met directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
