dongjoon-hyun commented on PR #851:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/851#issuecomment-5751983442
Thanks, @peter-toth! Rebased on `main` (which now carries #847) and
addressed 9 and 10.
- **10.** Took the split. `setPriority`, `getPodPriorityClass` and
`isPriorityClassChangeAllowed` moved to a new `KueueWorkloadPriority` class in
the same package, and `pmdMain` passes with no suppression on either class, so
the `@SuppressWarnings("PMD.GodClass")` I had added is gone. I kept the
priority tests in `KueueWorkloadUtilsTest`, since most of them exercise the
behavior through `requestAdmission` and share its helpers; only the direct
`setPriority` calls moved to the new class. Happy to split the test class too
if you prefer.
- **9.** Added `pendingWorkloadWithoutPriorityClassFollowsAnAddedLabel` as
written, and confirmed it fails when the quota-reserved short-circuit is
removed.
- **2.** Noted, thank you for catching that #847 removed the split. The
follow-up will introduce the get/create split itself and use both parts of the
gate.
One rebase note: #847's new `kueueTransientApiFailurePublishesNoEvent` tests
needed the same `priorityclasses().list()` stub as the other deep-stub clients
in those files, because Mockito cannot deep-stub the generic list. Only the
mock setup changed there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
