david-mollitor-db commented on PR #58906: URL: https://github.com/apache/spark/pull/58906#issuecomment-5770096605
Thanks @dongjoon-hyun. Addressed all three: retitled to "Skip the redundant second modulo ... for positive divisors", corrected the comment above `pmod` (it's non-negative for `n > 0` and shares the dividend's sign for `n < 0`), and made the `Byte`/`Short` overloads use the same three-line form as `Int`/`Long`. Rebased on master and re-pushed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
