cloud-fan commented on PR #58656:
URL: https://github.com/apache/spark/pull/58656#issuecomment-5771487320
Thanks for the update. The previous effective-reference and
configuration-name fixes are present. On the current head I still found two
nullable-IN gaps in the new inner-plan route: the safety walk stops at a
predicate-position InSubquery without inspecting its join condition, and the
legacy IN-nullability mode can normalize an observable `<=> false` use into a
form that bypasses the guard. I have included both concrete paths in the review.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:5764348512","thread_id":"conversation:5764348512","verdict_sha256":"5e51400791b44cf792d02bbc59d2837419644768a5d9aa2d5eb0b180f6ad74e1"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
