stevomitric commented on code in PR #58910:
URL: https://github.com/apache/spark/pull/58910#discussion_r4071647827
##########
sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala:
##########
@@ -655,7 +655,7 @@ class ExplainSuiteAE extends ExplainSuiteHelper with
EnableAdaptiveExecutionSuit
"""
Review Comment:
can we add some asserts on nullability? in `ArithmeticExpressionSuite`
perhaps.
##########
sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala:
##########
@@ -655,7 +655,7 @@ class ExplainSuiteAE extends ExplainSuiteHelper with
EnableAdaptiveExecutionSuit
"""
|(2) Filter [codegen id : 2]
|Input [1]: [id#xL]
- |Condition : ((id#xL > Subquery subquery#x, [id=#x]) AND
isnotnull((id#xL % 10)))
Review Comment:
Isn't there a CI scheduled job that runs with ANSII off so the isnotnull is
required in that case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
