Spenserrrr commented on code in PR #58903:
URL: https://github.com/apache/spark/pull/58903#discussion_r4078750661
##########
python/pyspark/sql/conversion.py:
##########
@@ -180,6 +181,26 @@ def select_columns(cls, batch: "pa.RecordBatch",
column_indices: list[int]) -> "
[batch.schema.names[i] for i in column_indices],
)
+ @classmethod
+ def concat_batches(cls, batches: Iterable["pa.RecordBatch"]) ->
"pa.RecordBatch":
Review Comment:
Agreed. I checked that both `pa.concat_batches` and the pre-19
`pa.concat_arrays` fallback already reject incompatible schemas. The size limit
depends on the Arrow type and buffer layout, so a generic precheck here would
be incomplete. I’ll keep the current behavior and let Arrow report these errors
for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
