dongjoon-hyun commented on code in PR #869:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/869#discussion_r4081178684
##########
docs/architecture.md:
##########
@@ -155,7 +155,7 @@ stateDiagram-v2
ResourceReleased --> [*]
%% Place TerminatedWithoutReleaseResources further to avoid overlap
- Failures --> TerminatedWithoutReleaseResources : Retain Policy
+ Failures --> TerminatedWithoutReleaseResources : Retain Policy, No Restart
Succeeded --> TerminatedWithoutReleaseResources
Review Comment:
Thank you. Added the `Retain Always, No Restart` label in f4fa67b.
##########
spark-operator-api/src/main/java/org/apache/spark/k8s/operator/status/ApplicationStatus.java:
##########
@@ -167,7 +167,7 @@ public ApplicationStatus terminateOrRestart(
if (exceededLimit) {
if (stateMessageOverride != null && !stateMessageOverride.isEmpty()) {
- stateMessage += stateMessageOverride;
+ stateMessage += " " + stateMessageOverride;
Review Comment:
Thank you. Tightened the assertion with `assertEquals` in f4fa67b. I also
verified that it fails without the space.
##########
spark-operator/src/main/java/org/apache/spark/k8s/operator/reconciler/reconcilesteps/AppCleanUpStep.java:
##########
@@ -195,10 +195,13 @@ public ReconcileProgress reconcile(
context, statusRecorder, state,
Duration.ofMillis(requeueAfterMillis));
} else {
+ // The resources have been released above. An application retaining them
has returned
+ // already, so it cannot terminate as
`TerminatedWithoutReleaseResources` here even if the
+ // retain policy applies and no more attempt is made.
Review Comment:
Thank you for filing SPARK-59734 and the note about the missing space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
