xiaoh1024 commented on code in PR #58948:
URL: https://github.com/apache/spark/pull/58948#discussion_r4080593727
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/PushDownUtils.scala:
##########
@@ -105,14 +116,22 @@ object PushDownUtils extends Logging {
val translatedFilters = mutable.ArrayBuffer.empty[Predicate]
val untranslatableExprs = mutable.ArrayBuffer.empty[Expression]
+ def translateFilter(expression: Expression): Option[Predicate] = {
+ DataSourceV2Strategy.translateFilterV2WithMapping(
+ expression, Some(translatedFilterToExpr))
+ }
+
for (filterExpr <- deterministicFilters) {
- val translated =
- DataSourceV2Strategy.translateFilterV2WithMapping(
- filterExpr, Some(translatedFilterToExpr))
- if (translated.isEmpty) {
- untranslatableExprs += filterExpr
- } else {
- translatedFilters += translated.get
+ translateFilter(filterExpr) match {
+ case Some(filter) =>
+ translatedFilters += filter
+ case None =>
+ untranslatableExprs += filterExpr
+ extractPushablePredicate(
+ filterExpr,
+ DataSourceV2Strategy.translateFilterV2)
+ .flatMap(translateFilter)
+ .foreach(translatedFilters += _)
Review Comment:
Thanks for catching this — fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
