dongjoon-hyun commented on PR #58972: URL: https://github.com/apache/spark/pull/58972#issuecomment-5799102949
Thank you for addressing the comments, @david-mollitor-db. The new tests look good to me; both fail without the `nullIntolerant` change, so they cover the new behavior. One remaining item: the PR description is missing the `### Was this patch authored or co-authored using generative AI tooling?` section from the PR template. Since the commit has `Co-authored-by: Isaac`, could you add that section with the `Generated-by: ...` line if applicable? Minor nit (non-blocking): because `CheckOverflow` is foldable when its child is foldable, `ConstantFolding` already folds `CheckOverflow(null literal)` in the real optimizer. The practical benefit here is mainly the `IsNotNull` inference and the `FilterExec` output nullability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
