cloud-fan commented on PR #58942:
URL: https://github.com/apache/spark/pull/58942#issuecomment-5799112116
The earlier AS-OF and non-join issues are addressed, but the shared
predicate still returns FullOuter for SMJ/SHJ even though both duplication
predicates are false, so validation admits a shape EnsureRequirements cannot
produce safely. Please exclude join types with no duplicable side and add a
focused full-outer refusal test.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:5793320348","thread_id":"conversation:5793320348","verdict_sha256":"7002bd93d18b8fa15754a55bc683c8e244b7f4075f2e4c2830048ddb01d81e20"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
