cloud-fan commented on code in PR #58419:
URL: https://github.com/apache/spark/pull/58419#discussion_r4090386652
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -8178,7 +8182,8 @@ object SQLConf {
.internal()
.doc("When set to true, the output partitioning of UnionExec will be the
same as the " +
"input partitioning if its children have same partitioning. Otherwise,
it will be a " +
- "default partitioning.")
+ "default partitioning. The value is read once per physical
preparation, so the exchanges " +
Review Comment:
**Nit (P3):** This still describes pass-through solely in terms of the
children's current partitioning. A union stamped plain during preparation
continues to report UnknownPartitioning if its children later acquire a common
concrete layout. Could you qualify the description with that preparation-time
decision so it matches what a prepared union can report?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
