dongjoon-hyun commented on PR #884: URL: https://github.com/apache/spark-kubernetes-operator/pull/884#issuecomment-5820781735
Thank you for the review, @peter-toth. I addressed all three comments in 3e3888d. - **1. (Blocking) The permit-direction E2E steps could not fail**: Added `set -e` to both steps, so a rejected label change now fails them. The `Submitted` and `ScheduledToRestart` entries stay out of the E2E test, since a label change in those short windows would make the test timing-dependent. - **2. `docs/operations.md`**: The values table and the Kueue prerequisites now mention the policy and the access that the installer needs to `validatingadmissionpolicies` and `validatingadmissionpolicybindings`. - **3. "once it started"**: The documentation now says that the policy reads only the status. A resource whose first status is not persisted yet may still change its label, and the operator keeps its admitted `Workload` in that case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
